-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TT-12702] revert wrappedServeHTTP to use recordDetail #6654
Conversation
Knock Knock! 🔍 Just thought I'd let you know that your PR title and story title look quite different. PR titles that closely resemble the story title make it easier for reviewers to understand the context of the PR. An easy-to-understand PR title a day makes the reviewer review away! 😛⚡️
Check out this guide to learn more about PR best-practices. |
PR Reviewer Guide 🔍Here are some key observations to aid the review process:
|
PR Code Suggestions ✨Explore these optional code suggestions:
|
API Changes no api changes detected |
b1f5e5b
to
4ecb4aa
Compare
4ecb4aa
to
177015b
Compare
Quality Gate failedFailed conditions |
API tests failure, and Otel e2e failures are not related to this PR |
User description
TT-12702
Description
This PR reverts https://github.com/TykTechnologies/tyk/pull/5716/files#diff-e6e07722257f7e41691e471185ad6d84fd56dc9e5459526ea32e9a5e8fa1a01bL518 - causing high memory consumption when handling large response payloads even when detailed recording is not enabled.
Related Issue
https://tyktech.atlassian.net/browse/TT-12702
Motivation and Context
How This Has Been Tested
Benchmarks
Master
PR branch
Benchstat
Screenshots (if appropriate)
Types of changes
Checklist
PR Type
Bug fix
Description
WrappedServeHTTP
function call to use therecordDetail
function, addressing a regression issue in handling larger payloads.Changes walkthrough 📝
reverse_proxy.go
Revert WrappedServeHTTP to use recordDetail function
gateway/reverse_proxy.go
WrappedServeHTTP
function call to userecordDetail
.WrappedServeHTTP
for improved requesthandling.